fix(files): Remove margin and width to not break layout#47600
Merged
Conversation
artonge
commented
Aug 29, 2024
Contributor
Author
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
/backport to stable30
skjnldsv
approved these changes
Aug 29, 2024
sorbaugh
approved these changes
Aug 29, 2024
Contributor
Author
|
/compile amend / |
artonge
force-pushed
the
artonge/fix/files_virtual_list_grid_view_layout_computation
branch
from
6a984a6 to
8e9453a
Compare
In grid view, this was messing with the reported available list width which was breaking the computed layout. Fix #47599 Signed-off-by: Louis Chemineau <louis@chmn.me> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
artonge/fix/files_virtual_list_grid_view_layout_computation
branch
from
8e9453a to
c42f010
Compare
artonge
deleted the
artonge/fix/files_virtual_list_grid_view_layout_computation
branch
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In grid view, this was messing with the reported available list width, which was breaking the computed layout.
Fix #47599